Date: Wed, 20 Mar 2002 20:57:10 +0000 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: audit@FreeBSD.ORG Subject: Re: Make find(1) standalone - commit candidate Message-ID: <200203202057.g2KKvA4j013529@grimreaper.grondar.org> In-Reply-To: <20020321072334.Q11390-100000@gamplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Thu, 21 Mar 2002 07:36:40 %2B1100." References: <20020321072334.Q11390-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, 20 Mar 2002 markm@FreeBSD.ORG wrote: > > OK, except there are now (surprisingly, only) 3 clones of getdate.y > (the others are in tar and cvs), and the yacc stuff in the Makefile > is as bogus as before. Would it make sense to put getdate.y into some library (libutil?) > The CLEANFILES lines have many style bugs: > - use of "+=" for the first initialization of a variable. > - duplicate getdate.c/parsedate.c. It is added automatically by bsd.prog.mk. > - bogus y.tab.h. y.tab.h is not created, since it is not in SRCS. getdate.h > is created instead (and automatically put in CLEANFILES). CLEANFILES removed. > The (missing) YFLAGS line has a style bug. The default YFLAGS is -d. This > causes getdate.h to be created and removed, but getdate.h is not used. > YFLAGS should be set to <nothing> to prevent this garbage. Null YFLAGS added. > See tar/Makefile and cvs/lib/Makefile for correct handling of getdate.y. Maybe these should use the (above) library? M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203202057.g2KKvA4j013529>