Date: Fri, 5 Apr 2002 18:49:19 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dima Dorfman <dima@trit.org> Cc: standards@FreeBSD.ORG Subject: Re: %j length modifier in kernel printf Message-ID: <20020405184249.S3947-100000@gamplex.bde.org> In-Reply-To: <20020405080000.754FB3E31@bazooka.trit.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 5 Apr 2002, Dima Dorfman wrote: > I've implemented the %j and %z (named %Z (for now?), since %z is > signed hex) length modifiers in the kernel printf(). The patch below > has been tested on i386, and appears to work okay. My primary concern > with it is breaking sign extension stuff; I've run tests to check that > I didn't break it completely, but it's very possible that I still > missed some corner cases. I don't like the restructuring of the code (lm functions). I think the kernel kvprintf should be much like the userland __vfprintf except for not having support for floating point (yet?) or the positional parameters bloat (ever). Are the significant complications for the extra formats in the kernel printf? > Also note that printf now uses intmax_t arithmetic even for shorter > types. This has some performance implications, but I don't think > kernel printf is used anywhere where such micropessimizations would be > noticeable. I agree, but this takes us further from the userland printf. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020405184249.S3947-100000>