Date: Mon, 8 Apr 2002 23:42:42 -0700 From: Alfred Perlstein <bright@mu.org> To: "M. Warner Losh" <imp@village.org> Cc: jhb@FreeBSD.org, kris@obsecurity.org, obrien@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ioccom.h Message-ID: <20020409064242.GJ93885@elvis.mu.org> In-Reply-To: <20020408.222429.22925353.imp@village.org> References: <20020408210151.B18407@xor.obsecurity.org> <XFMail.20020409001310.jhb@FreeBSD.org> <20020408.222429.22925353.imp@village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* M. Warner Losh <imp@village.org> [020408 21:24] wrote: > In message: <XFMail.20020409001310.jhb@FreeBSD.org> > John Baldwin <jhb@FreeBSD.org> writes: > : No, I already said that I reverted the ()'s locally and it still failed to > : compile. Yes, I was editing /usr/include/sys/ioccom.h and not > : /sys/sys/ioccom.h. I also tried putting __P() back in, but it didn't build > : then either. I'm wondering if the pollution in screen's osdef.h is new? > > Ah, the screen port. Lemme test this locally.... Hmmm, the new > version of iocomm doesn't work either: > > osdef.h:81: conflicting types for `ioctl' > /usr/include/sys/ioccom.h:75: previous declaration of `ioctl' > > The real problem is at osdef.h:81: > extern int ioctl __P((int, int, char *)); > > Note the two problems with this: > 1) int doesn't match unsgined long > 2) char * doesn't match ... > > screen needs to be fixed. here's a real patch: > > --- osdef.h.in.orig Mon Apr 8 22:22:18 2002 > +++ osdef.h.in Mon Apr 8 22:22:48 2002 > @@ -111,7 +111,9 @@ > extern int setpgid __P((int, int)); > extern int tcsetpgrp __P((int, int)); > #endif > +#ifndef __FreeBSD__ > extern int ioctl __P((int, int, char *)); > +#endif > > extern int kill __P((int, int)); > > I put this as misc/screen/files/patch-aj and screen just built. I don't have the emails offhand, but the screen people were pretty quick to respond to a help message from me. Have you contacted them about bringing in this fix? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020409064242.GJ93885>