Date: Thu, 11 Apr 2002 16:16:49 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/share/mk bsd.sys.mk Message-ID: <20020411160322.B3429-100000@gamplex.bde.org> In-Reply-To: <20020410180036.B84993@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Apr 2002, David O'Brien wrote: > On Wed, Apr 10, 2002 at 06:26:00PM +1000, Bruce Evans wrote: > > This gives me more to check before deciding if removing it easy enough :-). > > I think modifying the sources files to not produce syntax errors for > > foreign macros should be acceptable in most cases, since files in contrib > > should be portable so they can't depend on OS-dependent macros, > > Unfortunately when we take them from NetBSD they do. lukemftp and lukemftpd are counterexamples. I think most sources in contrib should be like this. > > and files > > outside of contrib get modified anyway. > > You did not respond to creating the non-standard /usr/include/scm.h as a > place to put all these various compatibility macros. I like it better than <sys/cdefs.h> for FreeBSD ids, but think it would just increase unportability. You would still have to edit files to add it, and it is not so easy to kill using Makefile hacks like -D__RCSID=__IGNORE where __IGNORE() expands to nothing. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020411160322.B3429-100000>