Date: Mon, 15 Apr 2002 11:22:42 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Joe O <joeo@cracktown.com> Cc: Frank Mayhar <frank@exit.com>, hackers@FreeBSD.ORG Subject: Re: Minor weirdness in pci/agp_amd.c. Message-ID: <20020415112242.A18576@freebsd.org> In-Reply-To: <20020415104315.N26711-100000@clubfoot.cracktown.com> References: <20020415103041.A18331@freebsd.org> <20020415104315.N26711-100000@clubfoot.cracktown.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-STABLE has been (as of late last week) brought up to speed as far as this fix goes. The earlier driver (shipped with 4.5) had this little oddity in it, but it was removed when the driver got re-written. It has been fixed, so there really is no problem. -- coleman On Mon, Apr 15, 2002 at 10:48:05AM -0400, Joe O wrote: > > This is probably the agp_amd.c driver from stable. It never got patched > up with the irongate fix that went into current. > > Look ether into agp_amd.c in current or look through PR database on the > the main freebsd website. > > > On Mon, 15 Apr 2002, Coleman Kane wrote: > > > Is this in the -STABLE or -CURRENT version? I've been working on getting this > > driver working, mostly from outside patches. > > > > -- > > coleman > > > > On Sun, Apr 14, 2002 at 04:57:17PM -0700, Frank Mayhar wrote: > > > I'm working on writing a driver for the ServerWorks AGP support from the > > > Linux driver (sans documentation, SIGH :-(). I've been using the various > > > other drivers as models, particularly the AMD driver, since it seems to be > > > closest in many ways to the ServerWorks architecture. > > > > > > Anyway, I've run into a minor oddity in agp_amd_alloc_gatt(), in pci/agp_amd.c. > > > At lines 120-121: > > > gatt->ag_pdir = vtophys((vm_offset_t) gatt->ag_vdir); > > > gatt->ag_pdir = vtophys(gatt->ag_virtual); > > > > > > Looks like one or the other is redundant? Probably the first, I would guess, > > > if the code actually works as it is. > > > -- > > > Frank Mayhar frank@exit.com http://www.exit.com/ > > > Exit Consulting http://www.gpsclock.com/ > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > with "unsubscribe freebsd-hackers" in the body of the message > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-hackers" in the body of the message > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-hackers" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020415112242.A18576>