Date: Thu, 18 Apr 2002 16:30:09 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Keiichi SHIMA / ????????? <keiichi@iij.ad.jp> Cc: freebsd-net@FreeBSD.ORG Subject: Re: Questions on ip_output.c's patch for FreeBSD-SA-02:21.tcpip Message-ID: <20020418133009.GB63157@sunbay.com> In-Reply-To: <20020418.200550.110156595.keiichi@iij.ad.jp> References: <200204171923.g3HJNg958905@freefall.freebsd.org> <x7vgapxy7o.wl@s30.crl.hitachi.co.jp> <20020418094722.GG98788@sunbay.com> <20020418.200550.110156595.keiichi@iij.ad.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2002 at 08:05:50PM +0900, Keiichi SHIMA / ????????? wrote: > Hi, >=20 > From: Ruslan Ermilov <ru@FreeBSD.ORG> >=20 > > I strongly object to this change. BSD historically didn't allow for > > ip_output() to be called with the NULL route pointer. I changed this >=20 > I don't know the history of BSD, but, if the reason is the history > (that BSD didn't allow NULL route), I agree your fix is the only way. >=20 > > in rev. 1.143 in a blind attempt to fix a panic condition I introduced > > in ip_icmp.c,v 1.64. Unfortunately, this didn't actually fix the > > ip_icmp.c bug but rather _hided_ it. Many respectful people objected > > to the 1.143 change, including Garrett Wollman, but I didn't realize > > at the time why this was bad. I since have fixed my mind, and I now > > realize why it's bad. The details could be found in the commit log > > for ip_output.c,v 1.153. Hopefully you can follow that. >=20 > If the reason is "Prevent icmp_reflect() from calling ip_output() with > a NULL route pointer which will then result in the allocated route's > ~~~~~~~~~~~~~~~~~~~~~ > reference count never being decremented.", I think both patches can > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fix this problem. >=20 The problem is _already_ fixed. And I don't want to fix similar problems in the future. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8vsphUkv4P6juNwoRAmygAJ0azYaagNtpvzAQ1VhKuJURfvP0GACdH3Qw 4q0p2xo4us+gLztE6Q3/n/8= =XiLD -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020418133009.GB63157>