Date: Mon, 22 Apr 2002 14:29:31 -0600 (MDT) From: "M. Warner Losh" <imp@village.org> To: mike@FreeBSD.org Cc: wollman@lcs.mit.edu, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c kern_exec.c src/sys/sys filedesc.h Message-ID: <20020422.142931.00009329.imp@village.org> In-Reply-To: <20020422160742.B8421@espresso.q9media.com> References: <20020418.220125.06947209.imp@village.org> <200204190420.g3J4KMC69617@khavrinen.lcs.mit.edu> <20020422160742.B8421@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20020422160742.B8421@espresso.q9media.com>
Mike Barcroft <mike@FreeBSD.org> writes:
: I agree that the current solution to this problem is wrong. I think
: the most correct solution would be to fix each set[ug]id program to
: ensure that it has a working set of the basic std{in,out,err}
: descriptors by making a series of fstat() calls and watching for a
: EBADF.
There are too many of them that don't do this, and more being added to
the tree all the time, esp in ports. There was a port that caused
this issue to boil up to the top of the list. Until such time as we
can guarnatee that all such setuid programs are perfect, we should
adopt a defensive posture.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020422.142931.00009329.imp>