Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 May 2002 21:01:05 +0100
From:      Brian Somers <brian@Awfulhak.org>
To:        Alfred Perlstein <bright@mu.org>
Cc:        Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/sysinstall index.c 
Message-ID:  <200205172001.g4HK15Ws096383@hak.lan.Awfulhak.org>
In-Reply-To: Message from Alfred Perlstein <bright@mu.org>  of "Fri, 17 May 2002 08:32:46 PDT." <20020517153246.GJ20683@elvis.mu.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
> * Brian Somers <brian@FreeBSD.org> [020517 02:49] wrote:
> > brian       2002/05/17 02:46:47 PDT
> > 
> >   Modified files:
> >     usr.sbin/sysinstall  index.c 
> >   Log:
> >   MFS: Extend a buffer size so that packages with particularily deep dependency
> >        lists install properly.
> >   
> >   Revision  Changes    Path
> >   1.97      +1 -1      src/usr.sbin/sysinstall/index.c
> 
> Why not use asprintf or something?  This code could use a bit of an
> overhaul, not another bandaid. :(

Well, I followed up to re@ that I'm going to commit to removing some 
of the buffer limitations & overflows in -current and MFC after the 
release - but I guess you've exposed my patch as a bandaid...  Grrr.

> -- 
> -Alfred Perlstein [alfred@freebsd.org]
> 'Instead of asking why a piece of software is using "1970s technology,"
>  start asking why software is ignoring 30 years of accumulated wisdom.'
> Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/

-- 
Brian <brian@Awfulhak.org>                    <brian@freebsd-services.com>
      <http://www.Awfulhak.org>;                   <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour !          <brian@[uk.]OpenBSD.org>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205172001.g4HK15Ws096383>