Date: Mon, 20 May 2002 14:49:20 -0400 From: Jake Burkholder <jake@locore.ca> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c Message-ID: <20020520144919.D62759@locore.ca> In-Reply-To: <20020520172431.GA97469@sunbay.com>; from ru@FreeBSD.org on Mon, May 20, 2002 at 08:24:31PM %2B0300 References: <200205200756.g4K7ueM28492@freefall.freebsd.org> <20020520121514.A62759@locore.ca> <20020520161739.GR73296@sunbay.com> <20020520172431.GA97469@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Apparently, On Mon, May 20, 2002 at 08:24:31PM +0300,
Ruslan Ermilov said words to the effect of;
> On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote:
> > On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote:
> > > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700,
> > > Ruslan Ermilov said words to the effect of;
> > >
> > > > ru 2002/05/20 00:56:40 PDT
> > > >
> > > > Modified files:
> > > > usr.bin/elf2aout elf2aout.c
> > > > Log:
> > > > s/u_int/u_int32_t/
> > >
> > > I would have preferred you to not commit this, it does nothing.
> > >
> > It makes code more MI, as u_int is not guaranteed to be 32 bit.
> > This also makes it explicit that we're dealing with the elf32
> > here, not elf64.
> >
> These would even better be declared using the Elf32_* types.
> Could you please fix this?
Umm, its an a.out header. u_int{,32_t} is correct.
>
>
> Cheers,
> --
> Ruslan Ermilov Sysadmin and DBA,
> ru@sunbay.com Sunbay Software AG,
> ru@FreeBSD.org FreeBSD committer,
> +380.652.512.251 Simferopol, Ukraine
>
> http://www.FreeBSD.org The Power To Serve
> http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020520144919.D62759>