Date: Tue, 21 May 2002 15:16:55 -0700 From: Alfred Perlstein <bright@mu.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, "Andrew R. Reiter" <arr@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern uipc_socket.c Message-ID: <20020521221655.GM54960@elvis.mu.org> In-Reply-To: <XFMail.20020521180307.jhb@FreeBSD.org> References: <20020521213720.GL54960@elvis.mu.org> <XFMail.20020521180307.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [020521 15:03] wrote: > > On 21-May-2002 Alfred Perlstein wrote: > > * Andrew R. Reiter <arr@FreeBSD.org> [020521 14:18] wrote: > >> arr 2002/05/21 14:18:41 PDT > >> > >> Modified files: > >> sys/kern uipc_socket.c > >> Log: > >> - OR the flag variable with M_ZERO so that the uma_zalloc() handles the > >> zero'ing out of the allocated memory. Also removed the logical bzero > >> that followed. > > > > This is just making something wrong prettier as well as obfuscating > > the problem and making the XXX comment not make sense. > > The XXX already didn't make sense. Why do you prefer explicit bzero() > to M_ZERO? The XXX made sense if you understand how the gencounts are used to detect out of date sockets when copying out statistics into userland. I don't prefer bzero over M_ZERO, I prefer him using the UMA callbacks to _properly_ bzero only the parts of the socket that need it. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020521221655.GM54960>