Date: Thu, 13 Jun 2002 21:55:09 +0200 From: Anton Berezin <tobez@tobez.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20020613195509.GA510@heechee.tobez.org> In-Reply-To: <3D08F0A2.A10E3D52@FreeBSD.org> References: <200206131820.g5DIKfB53863@freefall.freebsd.org> <3D08F0A2.A10E3D52@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 13, 2002 at 10:21:06PM +0300, Maxim Sobolev wrote:
> Maxim Sobolev wrote:
> > Add ${REINPLACE_CMD}, which will be used to get rid of depencency
> > on perl in current. Use it like the following:
> > ${REINPLACE_CMD} -e "foo" -e "bar" ${WRKSRC}/somefile
> >
> > Approved by: portmgr
> Be warned: it is not that easy to actually use it for complex regexs
> as you need to produce regex that works in the same way with perl and
> sed. For example regular expression which now looks like
> "s|\$\(foo\)/baz|\$\(bar\)/baz|g" and used for the most GNOME ports
> should be rewriten as "s|[$$][(]foo[)]/baz|\$$(bar)/baz|g". Therefore,
> simple sweep is nearly impossible and all individual maintainers are
> encouraged to fix their ports by themselves. And don't forget to test
> results both with perl and sed.
I think an extra warning might be in order here. It is possible, though
unlikely, that the extra .bak files produced with an application of
REINPLACE_CMD will accidentally get installed and thus break a valid
plist.
It might be better to consider removing the -i.bak from REINPLACE_CMD;
people who need it will be able to add it if necessary.
=Anton.
--
| Anton Berezin | FreeBSD: The power to serve |
| catpipe Systems ApS _ _ |_ | http://www.FreeBSD.org |
| tobez@catpipe.net (_(_|| | tobez@FreeBSD.org |
| +45 7021 0050 | Private: tobez@tobez.org |
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020613195509.GA510>