Date: Wed, 3 Jul 2002 09:59:56 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: Mark Murray <mark@grondar.za> Cc: audit@FreeBSD.ORG Subject: Re: lib/csu cleanup #2 - review please (commit candidate) Message-ID: <20020703095956.A8415@dragon.nuxi.com> In-Reply-To: <200206301924.g5UJOL07070228@grimreaper.grondar.org>; from mark@grondar.za on Sun, Jun 30, 2002 at 08:24:21PM %2B0100 References: <200206231830.g5NIUAa4045990@grimreaper.grondar.org> <200206301924.g5UJOL07070228@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 30, 2002 at 08:24:21PM +0100, Mark Murray wrote:
> In response to some useful comments from Bruce and David, I've
> cleaned this up, tested it on i386-elf (on my laptop) and extended
> it to the other architectures a lot more (limited testing, so
> please help out!).
But you didn't answer these questions:
> Index: alpha/crt1.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/csu/alpha/crt1.c,v
...
> +#ifndef lint
> +
> #ifndef __GNUC__
> #error "GCC is needed to compile this file"
> #endif
Please change Lint to note the #error but to continue processing. I've
pondered it and cannot find a good reason for Lint to "obey" #error.
> -_start(char *arguments, ...)
> +_start(char *ap, ...)
Why do we need to rename "arguments"?
> +extern int _DYNAMIC;
> +#pragma weak _DYNAMIC
Why? IMO #pragma's should come as early as possible.
(#also sorts before `e'xtern)
New questions:
> -_start(char **ap,
> - void (*cleanup)(void), /* from shared loader */
> - struct Struct_Obj_Entry *obj __unused, /* from shared loader */
> - struct ps_strings *ps_strings __unused)
> +_start(char **ap, void (*cleanup)(void), ...)
Why take a more exact prototype and definition to a lesser one?
> - fptr rtld_cleanup;
> + fptr cleanup;
...
> - rtld_cleanup = get_rtld_cleanup();
> + cleanup = get_rtld_cleanup();
Why do we need to rename this? (you also have a ^I above)
> diffs in i386-elf/crt1.c (Which I will commit separately; it
> has 4-space indents instead of tabs, and I'd like to fix that).
Why? This is not abandoned code. Our practice is to leave existing
style alone when making small changes.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020703095956.A8415>