Date: Thu, 12 Sep 2002 22:33:02 +0200 From: Mark Santcroos <marks@ripe.net> To: John Baldwin <jhb@FreeBSD.ORG> Cc: mobile@FreeBSD.ORG Subject: Re: pccard re-attach after ACPI S1 resume Message-ID: <20020912203302.GA1520@laptop.6bone.nl> In-Reply-To: <XFMail.20020912132505.jhb@FreeBSD.org> References: <20020912125118.GA1343@laptop.6bone.nl> <XFMail.20020912132505.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi John, On Thu, Sep 12, 2002 at 01:25:05PM -0400, John Baldwin wrote: > > + sc->suspended = 0; /* XXX initialize, maybe not here */ > > + > > /* > > * this is here so that when socket_enable calls gettype, trt happens > > */ > > This part you don't need because softc's are zero'd when they are allocated. Ok. But still I need it for the reason below. > What if you just had pccard_resume() always call pccard_attach_card(self), > does that work? Then we do an attach on a slot where we know there isn't anything anyway. That basicly doesn't make sense, and it also spits out all kind of ulgy messages that we don't want/need. > If not, you do have one bug, you should clear sc_suspended after > the pccard_attach_card() in pccard_resume(). No, that's why I set it to zero again in pccard_attach_card(). (Which is called for every slot that has sc->suspended==1) Btw, is this problem specific to me or is just nobody using/reporting this? It would seem like a generic problem. Mark -- Mark Santcroos RIPE Network Coordination Centre http://www.ripe.net/home/mark/ New Projects Group/TTM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020912203302.GA1520>