Date: Sat, 14 Sep 2002 03:33:58 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h Message-ID: <20020914032217.V10972-100000@gamplex.bde.org> In-Reply-To: <200209131128.g8DBSY14039266@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 13 Sep 2002, Poul-Henning Kamp wrote: > phk 2002/09/13 04:28:34 PDT > > Modified files: > sys/kern vfs_bio.c > sys/sys bio.h > Log: > Oops, broke the build there. Uninline biodone() now that it is non-trivial. > > Introduce biowait() function. Currently there is a race condition and the > mitigation is a timeout/retry. It is not obvious what kind of locking (if any) > is suitable for BIO_DONE, since the majority of users take are of this > themselves, and only a few places actually rely on the wakeup. > > Sponsored by: DARPA & NAI Labs. Isn't the "correct" locking just splbio() in RELENG_4 (if this function were merged, haha) and Giant in -current. bufwait() just uses splbio() unconditionally. Of course, Giant is not really correct. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020914032217.V10972-100000>