Date: Tue, 12 Nov 2002 15:55:47 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: current@freebsd.org Subject: Re: sshd: double "Last login:" bugfix spammed again Message-ID: <20021112125547.GA28874@nagual.pp.ru> In-Reply-To: <xzplm3z81ee.fsf@flood.ping.uio.no> References: <20021106141959.GA53561@nagual.pp.ru> <xzplm3z81ee.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 12, 2002 at 12:37:13 +0100, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > Old bugfix for double "Last login:" was spammed in 3rd time, causing
> > following printout:
>
> I can't reproduce this here.
Look at session.c, one "Last login" comes from
print_pam_messages();
and second one comes just few lines below under
if (options.print_lastlog ...
condition. Now look at the times:
Last login: Tue Nov 12 15:44:54 from xxx.yyy.zzz
^^^^^^^^
Last login: Tue Nov 12 15:38:01 2002 xxx.yyy.zzz
The first time from print_pam_messages() is wrong in anycase, it is JUST
login time, not LAST one! It clearly indicates that something wrong with
print_pam_messages().
We have two ways of fix:
1) Just disable print_pam_messages() ignoring what is wrong there.
2) Fix print_pam_messages() to print right time and remove second print
from sshd.
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021112125547.GA28874>