Date: Mon, 6 Jan 2003 10:21:54 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: freebsd-audit@freebsd.org Subject: Re: hopefully, a fix for an old uncompress(1) bug Message-ID: <20030106082154.GE1094@gothmog.gr> In-Reply-To: <20030106080949.GA382@straylight.oblivion.bg> References: <20030106062309.GA37109@gothmog.gr> <20030106080949.GA382@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2003-01-06 10:09, Peter Pentchev <roam@ringlet.net> wrote:
> On Mon, Jan 06, 2003 at 08:23:09AM +0200, Giorgos Keramidas wrote:
> > diff -u -5 -r1.20 compress.c
> > --- compress.c 28 Jul 2002 15:32:17 -0000 1.20
> > +++ compress.c 6 Jan 2003 06:15:06 -0000
> > @@ -298,26 +298,25 @@
> [snip]
> > if ((ifp = zopen(in, "r", bits)) == NULL) {
> > cwarn("%s", in);
> > - goto err;
> > + return;
>
> Is this change really needed? It is true that the code at 'err' would
> be a no-op at this point, when neither ifp nor ofp has been opened, but
> it strikes me as a bit more semantically correct to invoke the "real"
> error-handling procedures at any error, just in case something changes
> in the future and some error-handling does indeed become necessary.
Probably not. I'm happy with any of them two versions. Your diff is
even better since it reduces the changes to the absolute minimum.
- Giorgos
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030106082154.GE1094>