Date: Sun, 16 Feb 2003 16:04:10 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@FreeBSD.ORG Subject: Re: Console API related patch. Message-ID: <20030217000410.GA769@dhcp01.pn.xcllnt.net> In-Reply-To: <91629.1045428328@critter.freebsd.dk> References: <91629.1045428328@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 16, 2003 at 09:45:28PM +0100, Poul-Henning Kamp wrote:
>
> I am trying to do some weird things with some custom console code and
> got stuck on the fact that our console code belives all consoles have
> a dev_t.
>
> This patch changes the API so that rather than pass a "dev_t" to the
> console functions, the "struct consdev *" is passed:
>
> -typedef void cn_putc_t(dev_t, int);
> +typedef void cn_putc_t(struct consdev *, int);
>
> The dev_t can still be gotten hold of:
>
> int
> -zs_cncheckc(dev_t dev)
> +zs_cncheckc(struct consdev *cp)
> {
> int s = spltty();
> - int c = zs_maygetc(zs_console_addr, minor(dev));
> + int c = zs_maygetc(zs_console_addr, minor(cp->cn_dev));
> splx(s);
> return c;
> }
I like this. On the ia64 branch I completely ignore the dev argument
and instead use a static softc. The dev_t is unknown until after
bus enumeration in principle anyway.
> The patch compiles and runs on all platforms I can currently test,
> but I'd like if some of you can give it a spin too:
>
> http://phk.freebsd.dk/patch/console.patch
>
> The patch just does the not quite mechanical switch, some of the drivers
> could get some mileage from the cn_arg field but I have not tried that.
I'll test ia64, both CVS an P4. Let me know when you like to
commit this so that I can schedule around that...
--
Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030217000410.GA769>