Date: Thu, 26 Jun 2003 21:22:24 -0700 From: Kris Kennaway <kris@obsecurity.org> To: gnome@FreeBSD.org Subject: Buffer handling bugs in glimmer Message-ID: <20030627042224.GA77418@rot13.obsecurity.org>
next in thread | raw e-mail | index | archive | help
--uZ3hkaAS1mZxFaxD
Content-Type: multipart/mixed; boundary="45Z9DzgjV8m4Oswq"
Content-Disposition: inline
--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
The patches are attached. Can someone please test this?
Kris
----- Forwarded message from Anil Madhavapeddy <avsm@cvs.openbsd.org> -----
X-Original-To: kkenn@localhost
Delivered-To: kkenn@localhost.obsecurity.org
X-Originating-IP: [128.125.38.123]
Delivered-To: kris@freebsd.org
Date: Tue, 17 Jun 2003 08:06:42 -0600 (MDT)
From: Anil Madhavapeddy <avsm@cvs.openbsd.org>
To: ports-changes@cvs.openbsd.org
Subject: CVS: cvs.openbsd.org: ports
X-Spam-Level:=20
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
X-Loop: ports-changes@openbsd.org
Precedence: list
Reply-To: Anil Madhavapeddy <avsm@cvs.openbsd.org>
X-Bogosity: No, tests=3Dbogofilter, spamicity=3D0.000000, version=3D0.13.6
CVSROOT: /cvs
Module name: ports
Changes by: avsm@cvs.openbsd.org 2003/06/17 08:06:42
Modified files:
editors/glimmer: Makefile=20
Added files:
editors/glimmer/patches: patch-src_file-io_c patch-src_main_c=20
Log message:
patch a couple of too-small buffers that could lead to path truncation
maintainer ok, submitted upstream
----- End forwarded message -----
--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch-src_file-io_c
Content-Transfer-Encoding: quoted-printable
$OpenBSD: patch-src_file-io_c,v 1.1 2003/06/17 14:06:42 avsm Exp $
--- src/file-io.c.orig Tue Jun 17 01:52:36 2003
+++ src/file-io.c Tue Jun 17 01:53:49 2003
@@ -102,10 +102,10 @@ void
new_file_real (char *filename)
{
GnomeVFSURI *uri;
- gchar cwd[256];
+ gchar cwd[MAXPATHLEN];
gchar *full;
=20
- getcwd (cwd, 256);
+ getcwd (cwd, sizeof(cwd));
full =3D g_strconcat (cwd, "/", filename, NULL);
uri =3D gnome_vfs_uri_new (full);
g_free (full);
--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch-src_main_c
Content-Transfer-Encoding: quoted-printable
$OpenBSD: patch-src_main_c,v 1.1 2003/06/17 14:06:42 avsm Exp $
--- src/main.c.orig Tue Jun 17 01:53:17 2003
+++ src/main.c Tue Jun 17 01:54:18 2003
@@ -342,7 +342,7 @@ main_finish (void *closure, int argc, ch
gchar *path;
gchar *file;
gchar *full;
- gchar cwd[256];
+ gchar cwd[MAXPATHLEN];
=20
args =3D (gchar **) poptGetArgs (pctx);
=20
@@ -381,7 +381,7 @@ main_finish (void *closure, int argc, ch
}
}
if (input_file) {
- gchar *path, *file, *full, cwd[256];
+ gchar *path, *file, *full, cwd[MAXPATHLEN];
=20
getcwd (cwd, sizeof (cwd));
path =3D get_path_from_filename (input_file);
--45Z9DzgjV8m4Oswq--
--uZ3hkaAS1mZxFaxD
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)
iD8DBQE++8aAWry0BWjoQKURAuJ0AJ9+OMHN+hpWkXtC5J2lcvwoeyKMowCg7de8
InEerTqBZmB2zM6SRaWVEBI=
=cZxy
-----END PGP SIGNATURE-----
--uZ3hkaAS1mZxFaxD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030627042224.GA77418>