Date: Tue, 19 Aug 2003 07:09:40 -0700 From: Orion Hodson <orion@freebsd.org> To: Rudolf Cejka <cejkar@fit.vutbr.cz> Cc: hackers@freebsd.org Subject: Re: ASUS P4P800-VM + AD1980 (Was Re: VIA8235 + AD1980) Message-ID: <200308191409.h7JE9eTU013118@puma.icir.org> In-Reply-To: Your message of "Tue, 19 Aug 2003 09:55:18 %2B0200." <20030819075518.GA75416@fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
/-- Rudolf Cejka wrote: | Rudolf Cejka wrote (2003/08/18): | > my "another machine" is at home, so I will be sure about your patch | > tomorrow and I will send you another mail, however it looks reasonably. | > Maybe just for "defensive programming" wouldn't it be "safer" to switch | > values instead of assignment? Maybe there are some boards, which can use | > both outputs... | | So, I have tested your patch (machine with AD1885) and it works for me, | however it would be really better to switch values instead of assignment | even in my case just with HP_OUT connected. With an assignment, it is | possible to control main volume by two independent controls, | SOUND_MIXER_VOLUME and SOUND_MIXER_MONITOR, and if I change one of them, | then there is an inconsistency between the real volume state and the other | control. Thank you for the info regarding the patch. Rather than "defensively" assign the input monitor control (SOUND_MIXER_MONITOR) to an output, it'd be better to use a separate output control, eg add a control for SOUND_MIXER_OGAIN, should it actually be necessary. Cheers - Orion
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308191409.h7JE9eTU013118>