Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Aug 2003 17:20:13 +0900
From:      HATANOU Tomomi <hatanou@infolab.ne.jp>
To:        freebsd-current@freebsd.org
Subject:   Re: HEADS UP! ATAng committed
Message-ID:  <200308250820.h7P8KDp2063902@mercury.infolab.ne.jp>
In-Reply-To: S,Axren Schmidt's message of "Sun, 24 Aug 2003 15:28:45 %2B0200." <200308241328.h7ODSjwC067165@spider.deepcore.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
>> Coolness. Judging from the CVS log, it also gets ATA out under Giant? 
>
>Yes it does.

I've noticed that, in ata-raid.c:ar_rebuid(), Giant is
locked and never unlocked.  Is it ok?

% ident ata-raid.c
ata-raid.c:
     $FreeBSD: src/sys/dev/ata/ata-raid.c,v 1.67 2003/08/24 17:48:05 obrien Exp $
% grep Giant ata-raid.c
    mtx_lock(&Giant);
%

HATANOU Tomomi
infolab.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308250820.h7P8KDp2063902>