Date: Wed, 17 Sep 2003 10:48:05 +0200 From: Bernd Walter <ticso@cicely12.cicely.de> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: panic: Negative bio_offset (-15050100712783872) on bio 0xc7725d50 Message-ID: <20030917084804.GX26878@cicely12.cicely.de> In-Reply-To: <25110.1063787415@critter.freebsd.dk> References: <20030917082738.GW26878@cicely12.cicely.de> <25110.1063787415@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 17, 2003 at 10:30:15AM +0200, Poul-Henning Kamp wrote: > In message <20030917082738.GW26878@cicely12.cicely.de>, Bernd Walter writes: > >On Wed, Sep 17, 2003 at 09:07:24AM +0200, Poul-Henning Kamp wrote: > >> In message <20030916102534.J2924@gamplex.bde.org>, Bruce Evans writes: > >> > >> >This is either disk corruption or an ffs bug. ffs passes the garbage > >> >block number 0xffffe5441ae9720 to bread. GEOM then handles this austerely > >> >by panicing. Garbage block numbers, including negative ones, can possibly > >> >be created by applications seeking to preposterous offsets, so they should > >> >not be handled with panics. > >> > >> They most certainly should! If the range checking in any filesystem > >> is not able to catch these cases I insist that GEOM do so with a panic. > > > >What is wrong with returning an IO error? > > > >I always hated panics because of filesystem corruptions. > >An alternative would be to just bring that filesystem down. > >Its easy to panic a whole system with a bogus filesystem on a removeable > >media. > > I hate panics too, but this would be an indication of a serious > filesystem error, so a panic is in order. Otherwise we would be > unlikely to ever receive a report which would allow us to fix > the problem. Don't you think that people will report them if the filesystem is automatically unmounted? Accepted that's not an option for the GEOM point and that panicing here can be good to fix range checking in the filesystem. -- B.Walter BWCT http://www.bwct.de ticso@bwct.de info@bwct.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030917084804.GX26878>