Date: Mon, 26 Jan 2004 17:13:00 +0100 From: Pawel Jakub Dawidek <nick@garage.freebsd.pl> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-geom@freebsd.org Subject: Re: Preventing deadlocks on the event queue. Message-ID: <20040126161300.GJ565@garage.freebsd.pl> In-Reply-To: <20040126164924.C90355@pcle2.cc.univie.ac.at> References: <20040125234848.GH565@garage.freebsd.pl> <20040126164924.C90355@pcle2.cc.univie.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jan 26, 2004 at 04:50:38PM +0100, Lukas Ertl wrote: +> > So, I think I've found clever way to prevents deadlock caused by +> > calling g_waitfor_event() from an event. +> > +> > My idea is to check if curthread in g_waitfor_event() is a g_event thread. +> > +> > http://garage.freebsd.pl/patches/geom_event_deadlock.patch +> +> Do you really want to make this a separate function? Since it's just a +> one-line comparison, wouldn't a macro suffice? I want to avoid exporting 'g_event_proc' from geom_kern.c (it is declareted staticaly there). -- Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBQBU8jD/PhmMH/Mf1AQEOjwQAiCGlv4I//+SCIlo4E/2UR9x01qEIJLU0 Z6gDU0dj6OJImVCdj3mih3/0C9KWaeQCRx/BrU9rkxZ0Ji9dcsIb5moP/oxMifwr +F/lBc57rZQdiD/iOOzz3e3hzNgjRAWgwSQ2Vdi4fNpZklZjFNKMtAe6B9DTnnEE o6aBr0LllAM= =Yah5 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040126161300.GJ565>