Date: Wed, 25 Feb 2004 19:55:53 +0100 From: Johan Karlsson <johan@freebsd.org> To: ipfw@freebsd.org Subject: WARNS cleanup for ip6fw Message-ID: <20040225185553.GA53607@numeri.campus.luth.se>
next in thread | raw e-mail | index | archive | help
--1yeeQ81UyVL57Vl7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hi
I intend to commit the attached patch to make ip6fw WARNS=2
clean.
It removes an unused variable and includes <timeconv.h> to get
a prototype for the _long_to_time function.
Any objections?
/Johan K
--
Johan Karlsson mailto:johan@FreeBSD.org
--1yeeQ81UyVL57Vl7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ip6fw.diff"
Index: sbin/ip6fw/Makefile
===================================================================
RCS file: /home/ncvs/src/sbin/ip6fw/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- sbin/ip6fw/Makefile 23 Feb 2004 20:13:52 -0000 1.5
+++ sbin/ip6fw/Makefile 25 Feb 2004 18:44:20 -0000
@@ -1,7 +1,7 @@
# $FreeBSD: src/sbin/ip6fw/Makefile,v 1.5 2004/02/23 20:13:52 johan Exp $
PROG= ip6fw
-WARNS?= 0
+WARNS?= 2
MAN= ip6fw.8
.include <bsd.prog.mk>
Index: sbin/ip6fw/ip6fw.c
===================================================================
RCS file: /home/ncvs/src/sbin/ip6fw/ip6fw.c,v
retrieving revision 1.16
diff -u -r1.16 ip6fw.c
--- sbin/ip6fw/ip6fw.c 18 Feb 2004 15:56:53 -0000 1.16
+++ sbin/ip6fw/ip6fw.c 25 Feb 2004 18:47:30 -0000
@@ -68,6 +68,7 @@
#include <stdarg.h>
#include <string.h>
#include <time.h>
+#include <timeconv.h>
#include <unistd.h>
#include <errno.h>
#include <signal.h>
@@ -839,8 +840,6 @@
ifu->fu_via_ip6 = in6addr_any;
*byname = 0;
} else if (!isdigit(*arg)) {
- char *q;
-
*byname = 1;
strlcpy(ifu->fu_via_if.name, arg, sizeof(ifu->fu_via_if.name));
/*
--1yeeQ81UyVL57Vl7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040225185553.GA53607>