Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 May 2004 21:15:39 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 52156 for review
Message-ID:  <20040507211416.H51922@root.org>
In-Reply-To: <200405031911.i43JBPk7000313@repoman.freebsd.org>
References:  <200405031911.i43JBPk7000313@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 May 2004, John Baldwin wrote:
> http://perforce.freebsd.org/chv.cgi?CH=52156
>
> Change 52156 by jhb@jhb_slimer on 2004/05/03 12:10:39
>
> 	Bah, revert accidental submits.  Neither of these worked on my
> 	laptop, though the acpi_video one does work for some people and
> 	might should be committed.
>
> Affected files ...
>
> .. //depot/projects/power/sys/dev/acpica/acpi_video.c#4 edit
> .. //depot/projects/power/sys/isa/vga_isa.c#5 edit

The DPMS stuff should go in a different device driver than acpi_video.  It
is a MI driver that implements only the standard ACPI interfaces.  DPMS is
probed separately and should be in a separate driver.  You can have DPMS
without ACPI too.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040507211416.H51922>