Date: Wed, 14 Jul 2004 02:40:15 GMT From: Wesley Shields <wxs@csh.rit.edu> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/69024: Please portlint [databases/mysqltcl] Message-ID: <200407140240.i6E2eFWD093435@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/69024; it has been noted by GNATS.
From: Wesley Shields <wxs@csh.rit.edu>
To: Adam Weinberger <adamw@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/69024: Please portlint [databases/mysqltcl]
Date: Tue, 13 Jul 2004 22:34:38 -0400
On Tue, Jul 13, 2004 at 10:26:00PM -0400, Adam Weinberger wrote:
> >> (07.13.2004 @ 2137 PST): Wesley Shields said, in 1.5K: <<
> > databases/mysqltcl does not please portlint.
> > This is the second in a series of patches to make ports please portlint.
> > diff -ruN databases/mysqltcl.orig/Makefile databases/mysqltcl/Makefile
> > --- databases/mysqltcl.orig/Makefile Sun Jul 11 11:51:42 2004
> > +++ databases/mysqltcl/Makefile Sun Jul 11 11:52:02 2004
> > @@ -34,6 +34,6 @@
> > > ${SQL_DIR}/pkgIndex.tcl
> > ${INSTALL_MAN} ${WRKSRC}/doc/${MANN} ${PREFIX}/man/mann
> >
> > -.include <bsd.port.mk>
> > -
> > LIB_NAME!= ${MAKE_ENV} ${MAKE} -f ${FILESDIR}/Makefile.bsd -V SHLIB_NAME
> > +
> > +.include <bsd.port.mk>
> >> end of "ports/69024: Please portlint [databases/mysqltcl]" from Wesley Shields <<
>
> Are you testing these changes or just submitting them?
>
> There are certain instances where stuff must come after ".include
> <bsd.port.mk>" in order to function properly.
>
> # Adam
Not all of the 20 I just submitted have been tested (mainly because it
would take forever to build quite a few of these), but those that I
could test quickly I did.
I apologize for this and now that I know it can be required for stuff to
come after bsd.port.mk I will test all of my submissions when trying to
make things please portlint.
I decided to submit the first batch to see how they went over. If there
are any mistakes in the other ones I just submitted please close them
and I will resubmit with a properly tested patch.
My apologies for this mistake.
-- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407140240.i6E2eFWD093435>