Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Oct 2004 10:34:56 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        soralx@cydem.org
Cc:        freebsd-hackers@freebsd.org
Subject:   Re: [PATCH] Re: Linksys PCM200
Message-ID:  <20041021173456.GA20517@odin.ac.hmc.edu>
In-Reply-To: <200410171122.28021.soralx@cydem.org>
References:  <200410132110.09915.soralx@cydem.org> <200410171122.28021.soralx@cydem.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 20, 2004 at 10:59:50PM -0600, soralx@cydem.org wrote:
>=20
> [got no answer on hardware@]
>=20
> I've tested this on 5.3-BETA7 - works OK, no more watchdog timeouts.
> So could someone review those patches and add them to the source tree?
> It's probably a good idea to update dc(4) and supported hw list also.

I'm looking at this, though I have no hardware to test with.  This patch
suffers from cut-n-paste dammage and can not be applied directly.
Please be more careful with this sort of thing in the future.

> @@ -1978,6 +1982,7 @@
>         case DC_DEVICEID_3CSOHOB:
>         case DC_DEVICEID_MSMN120:
>         case DC_DEVICEID_MSMN130_FAKE: /* XXX avoid collision with PNIC*/
> +	case DC_DEVICEID_PCM200_AB09:
>                 sc->dc_type =3D DC_TYPE_AN985;
>                 sc->dc_flags |=3D DC_64BIT_HASH;
>                 sc->dc_flags |=3D DC_TX_USE_TX_INTR;

Should there be an DC_DEVICEID_PCM200_AB08 here?  It certaintly looks
like it won't work otherwise.

Thanks for you submission.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--UlVJffcvxoiEqYs2
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBd/M/XY6L6fI4GtQRAllRAJ4vaQbzYBV38XXBSyqMqi3GBk6+/QCgsE2+
q/A0lE42UhbYZ++s8R5oWEw=
=cbjx
-----END PGP SIGNATURE-----

--UlVJffcvxoiEqYs2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041021173456.GA20517>