Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Oct 2004 21:14:06 +0200
From:      Gilbert Cao <hika@bsdmon.com>
To:        Max Laier <max@love2party.net>
Cc:        freebsd-net@freebsd.org
Subject:   Re: Kernel panic with pf
Message-ID:  <20041024191406.GA1022@bsdmon.com>
In-Reply-To: <200410241848.35446.max@love2party.net>
References:  <20041024144754.GA1670@bsdmon.com> <200410241722.34910.max@love2party.net> <20041024160235.GA1016@bsdmon.com> <200410241848.35446.max@love2party.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 24, 2004 at 06:48:28PM +0200, Max Laier wrote:
> 
> Hmmm ... that's bad. Can you please test the attached patch. It is a wild 
> guess as I am currently not able to test. Please tell me if it helps.
> 
> -- 
> /"\  Best regards,                      | mlaier@freebsd.org
> \ /  Max Laier                          | ICQ #67774661
>  X   http://pf4freebsd.love2party.net/  | mlaier@EFnet
> / \  ASCII Ribbon Campaign              | Against HTML Mail and News

> Index: pf.c
> ===================================================================
> RCS file: /usr/store/mlaier/fcvs/src/sys/contrib/pf/net/pf.c,v
> retrieving revision 1.18.2.2
> diff -u -r1.18.2.2 pf.c
> --- pf.c	3 Oct 2004 17:04:39 -0000	1.18.2.2
> +++ pf.c	24 Oct 2004 16:45:33 -0000
> @@ -2506,6 +2506,11 @@
>  	}
>  #ifdef __FreeBSD__
>  	INP_LOCK(inp);
> +	if ((inp->inp_socket == NULL) || (inp->inp_socket->so_cred == NULL)) {
> +		INP_UNLOCK(inp);
> +		INP_INFO_RUNLOCK(pi);
> +		return (0);
> +	}
>  	*uid = inp->inp_socket->so_cred->cr_uid;
>  	*gid = inp->inp_socket->so_cred->cr_groups[0];
>  	INP_UNLOCK(inp);

  Thanks.
That works, no panic.

Should I also test with debug.mpsafenet=0, or is it useless ?

Gilbert Cao.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041024191406.GA1022>