Date: Fri, 3 Dec 2004 11:42:01 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci.c Message-ID: <20041203194201.GB16093@ns1.xcllnt.net> In-Reply-To: <20041203.110520.54185564.imp@bsdimp.com> References: <200412030813.iB38DA12044595@repoman.freebsd.org> <20041203.110520.54185564.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 03, 2004 at 11:05:20AM -0700, M. Warner Losh wrote: > In message: <200412030813.iB38DA12044595@repoman.freebsd.org> > Nate Lawson <njl@FreeBSD.org> writes: > : njl 2004-12-03 08:13:09 UTC > : > : FreeBSD src repository > : > : Modified files: > : sys/dev/pci pci.c > : Log: > : Non-x86 platforms cannot use the ACPI includes. This should be fixed but > : for now, only include the headers for i386, amd64, or ia64. > : > : Pointed out by: grehan > > We likely should have a sys/$MACHINE_ARCH/include/_config.h that has a > bunch of #defines that we can test instead of specific architecture > lists, don't you think? A <machine/_config.h> doesn't give me warm fuzzies. Maybe we can rename <machine/pci_cfgreg.h> to <machine/pci.h> and give it some additional use (for this particular case of course). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041203194201.GB16093>