Date: Wed, 15 Dec 2004 14:54:22 -0700 From: Tony Arcieri <tarcieri@atmos.colostate.edu> To: David Schultz <das@FreeBSD.ORG> Cc: freebsd-current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sched_ule.c (fwd) Message-ID: <20041215215422.GA19373@flash.atmos.colostate.edu> In-Reply-To: <20041215214050.GA64783@VARK.MIT.EDU> References: <20041214222444.GA9668@flash.atmos.colostate.edu> <3308.192.168.1.9.1103065723.squirrel@192.168.1.9> <20041215001222.GB9957@flash.atmos.colostate.edu> <41BF9130.9070907@freebsd.org> <20041215152931.H60504@mail.chesapeake.net> <20041215210119.GF17276@flash.atmos.colostate.edu> <20041215214050.GA64783@VARK.MIT.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 15, 2004 at 04:40:50PM -0500, David Schultz wrote:
> On Wed, Dec 15, 2004, Tony Arcieri wrote:
> > And am I correct that the UMA implementation in RELENG_5 has rendered
> > proc_fini() obsolete and thus it won't ever be called?
>
> This has very little to do with either UMA or ULE. Yes, it's
> unused, but it's still there as a reminder that it *ought* to be
> used. Unless there are still races I don't know about, it's
> probably safe to start using it again.
Well, I'm going by the comments and implementation from kern_proc.c in HEAD:
/*
* UMA should ensure that this function is never called.
* Freeing a proc structure would violate type stability.
*/
static void
proc_fini(void *mem, int size)
{
panic("proc reclaimed");
}
The implementation in RELENG_5 invokes a scheduler function which is no
longer present in HEAD.
Tony Arcieri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041215215422.GA19373>