Date: Tue, 25 Jan 2005 17:43:33 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Michael Sierchio <kudzu@tenebras.com> Cc: lioux@FreeBSD.org Subject: Re: FreeBSD Port: qmail-1.03_3 Message-ID: <20050126014333.GA76808@xor.obsecurity.org> In-Reply-To: <41F6F431.6060005@tenebras.com> References: <41F6F431.6060005@tenebras.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 25, 2005 at 05:36:49PM -0800, Michael Sierchio wrote: >=20 > You have added a patch which is totally unneccesary, and I > suggest that it be removed: >=20 > in your patch-qmail-local.... >=20 > - while ((k > i) && (cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D= =3D '\t')) > + while ((k > i) && ((cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D= =3D '\t'))) >=20 > This is totally bogus, the original code is correct. Please do not > make changes to contributed code simply because it makes it easier > for you to understand. There is no semantic difference between the > two, ERGO the patch should not exist. Please remove it. >=20 > Shall I file a PR? You could try sending a more politely worded email next time. Kris --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB9vXFWry0BWjoQKURAj4gAJ9LEt7Z+X/wiMQF326OBWtzp9BvOgCeNSmB LA3q7hIUK6b76lVgqDhJC+M= =T7hM -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050126014333.GA76808>