Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Feb 2005 00:27:55 -0500
From:      Jung-uk Kim <jkim@niksun.com>
To:        freebsd-amd64@freebsd.org, cokane@cokane.org
Subject:   Re: [PATCH] Updated quirk-driven R3000Z patches
Message-ID:  <200502160027.55420.jkim@niksun.com>
In-Reply-To: <346a80220502151437627a9ef6@mail.gmail.com>
References:  <200502141722.10259.jhb@FreeBSD.org> <200502151659.42594.nb_root@videotron.ca> <346a80220502151437627a9ef6@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Boundary-00=_bntECfMDi4sZ2i6
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Tuesday 15 February 2005 05:37 pm, Coleman Kane wrote:
> Hi, I tested the patch posted by John on a compaq R3000. Works
> great, except still requires device atpic (for the mixed_mode
> operation I think). Kim posted a patch in this email:
> http://lists.freebsd.org/pipermail/freebsd-amd64/2005-January/00337
>6.html. I dunno if the patch is kosher or not, however. It does
> allow me to run without using atpic.

Ouch, you're absolutely correct.  jhb's patch wasn't complete for 
amd64.  The missing piece is attached.  Can you please re-test?

Thanks,

Jung-uk Kim

--Boundary-00=_bntECfMDi4sZ2i6
Content-Type: text/plain;
  charset="iso-8859-1";
  name="r3000-amd64.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="r3000-amd64.diff"

--- src/sys/amd64/amd64/io_apic.c.orig	Mon Aug 16 19:12:29 2004
+++ src/sys/amd64/amd64/io_apic.c	Wed Feb 16 00:21:23 2005
@@ -548,10 +548,11 @@
 
 		/*
 		 * Assume that pin 0 on the first I/O APIC is an ExtINT pin
-		 * and that pins 1-15 are ISA interrupts.  Assume that all
+		 * if mixed mode is enabled and an ISA interrupt if not.
+		 * Assume that pins 1-15 are ISA interrupts and that all
 		 * other pins are PCI interrupts.
 		 */
-		if (intpin->io_vector == 0)
+		if (intpin->io_vector == 0 && mixed_mode_enabled)
 			ioapic_set_extint(io, i);
 		else if (intpin->io_vector < IOAPIC_ISA_INTS) {
 			intpin->io_bus = APIC_BUS_ISA;

--Boundary-00=_bntECfMDi4sZ2i6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502160027.55420.jkim>