Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Feb 2005 13:51:49 +0100
From:      Francois Tigeot <ftigeot@wolfpond.org>
To:        Jeff Roberson <jroberson@chesapeake.net>
Cc:        stable@freebsd.org
Subject:   Re: Merging phk's filedesc cleanup and lock pushdown.
Message-ID:  <20050224125148.GA22855@aoi.wolfpond.org>
In-Reply-To: <20050224031645.A86246@mail.chesapeake.net>
References:  <20050224031645.A86246@mail.chesapeake.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 24, 2005 at 03:18:49AM -0500, Jeff Roberson wrote:
> I am going to MFC phk's filedesc related work in the next few days.  This
> is required if I am ever to merge the vfs smp changes.  I have a patch
> available at:
> 
> http://www.chesapeake.net/~jroberson/fdesc.patch
> 
> I'd appreciate it if anyone who can would test this.  It has been running
> on current for 3-4 months, depending on the bit, but there's always a
> chance of a botched merge.

World doesn't build with this patch:

cc -O -pipe -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c
/usr/src/usr.bin/fstat/fstat.c
/usr/src/usr.bin/fstat/fstat.c: In function `dofiles':
/usr/src/usr.bin/fstat/fstat.c:325: error: storage size of 'filed0' isn't known
/usr/src/usr.bin/fstat/fstat.c:363: error: `NDFILE' undeclared (first use in this function)
/usr/src/usr.bin/fstat/fstat.c:363: error: (Each undeclared identifier is reported only once
/usr/src/usr.bin/fstat/fstat.c:363: error: for each function it appears in.)
/usr/src/usr.bin/fstat/fstat.c:325: warning: unused variable `filed0'
*** Error code 1

Stop in /usr/src/usr.bin/fstat.
*** Error code 1

Stop in /usr/src/usr.bin.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
nice make buildworld  1209,00s user 251,75s system 78% cpu 31:04,65 total

This machine is an amd64 5.3-STABLE host. The same sources build nicely
without the patch.

-- 
Francois Tigeot



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050224125148.GA22855>