Date: Wed, 4 May 2005 00:48:52 +0300 (EEST) From: Vladimir Kushnir <vkushnir@i.kiev.ua> To: freebsd-multimedia@freebsd.org Subject: Re: New ffmpeg CVS versions Message-ID: <20050504003425.A97449@kushnir1.kiev.ua> In-Reply-To: <20050503070628.GF11140@puff.jakemsr.gom> References: <20050502043610.51034.qmail@exxodus.fedaykin.here> <4275B154.5070007@ahze.net> <20050503070628.GF11140@puff.jakemsr.gom>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 3 May 2005, Jacob Meuser wrote: <snip> > > notes on grab_bsdbktr.c > <snip> > i think av_set_pts_info() needs to be moved up to before other > parameters in 's' are set in grab_read_header(). Actually, with av_set_pts_info() as it is grabbing doesn't work even in the present ffmpeg port. It should be av_set_pts_info(st, 48, 1, 1000000); not av_set_pts_info(s1, 48, 1, 1000000); (as av_set_pts_info() takes AVStream and not AVFormatContext). With this change ffmpeg grabs even without any move. > > i'm pretty sure the av_free() in grab_read_close() can result in > double free errors, i.e. ffmpeg free()s the memory automagically. Yep, it does. Regards, Vladimir
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050504003425.A97449>