Date: Tue, 10 May 2005 20:36:20 -0400 From: Mikhail Teterin <mi+mx@aldan.algebra.com> To: re@FreeBSD.org Cc: stable@FreeBSD.org Subject: PTHREAD_INVARIANTS in 5.x Message-ID: <200505102036.21194.mi%2Bmx@aldan.algebra.com>
next in thread | raw e-mail | index | archive | help
--Boundary-00=_FOVgCBOYinB9LG1 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello! As we were counting down to 5.3-RELEASE, I noticed, that all threading libraries still compile with PTHREAD_INVARIANTS. My suggestion to have this fixed was shutdown as not enough time was left for testing the 5.3. 6 months later the much anticipated 5.4 ships with these defines again and again FreeBSD is going to lose all thread-using benchmarks out there (such as MySQL's)... Can we have these things turned off NOW, so that, at least, 5.5 stands a chance? Thanks! -mi --Boundary-00=_FOVgCBOYinB9LG1 Content-Type: text/x-diff; charset="us-ascii"; name="inva.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="inva.patch" Index: lib/libc_r/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libc_r/Makefile,v retrieving revision 1.39.2.1 diff -U2 -r1.39.2.1 Makefile --- lib/libc_r/Makefile 13 Feb 2005 07:23:12 -0000 1.39.2.1 +++ lib/libc_r/Makefile 11 May 2005 00:22:12 -0000 @@ -19,5 +19,5 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS +#CFLAGS+=-D_PTHREADS_INVARIANTS PRECIOUSLIB= Index: lib/libpthread/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libpthread/Makefile,v retrieving revision 1.52.2.1 diff -U2 -r1.52.2.1 Makefile --- lib/libpthread/Makefile 13 Feb 2005 07:23:13 -0000 1.52.2.1 +++ lib/libpthread/Makefile 11 May 2005 00:22:23 -0000 @@ -35,5 +35,6 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS -Wall +#CFLAGS+=-D_PTHREADS_INVARIANTS -Wall +CFLAGS+=-Wall PRECIOUSLIB= Index: lib/libthr/Makefile =================================================================== RCS file: /meow/ncvs/src/lib/libthr/Makefile,v retrieving revision 1.7.2.1 diff -U2 -r1.7.2.1 Makefile --- lib/libthr/Makefile 13 Feb 2005 07:23:15 -0000 1.7.2.1 +++ lib/libthr/Makefile 11 May 2005 00:22:27 -0000 @@ -17,5 +17,5 @@ # enable extra internal consistancy checks -CFLAGS+=-D_PTHREADS_INVARIANTS +#CFLAGS+=-D_PTHREADS_INVARIANTS PRECIOUSLIB= --Boundary-00=_FOVgCBOYinB9LG1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505102036.21194.mi%2Bmx>