Date: Wed, 11 May 2005 09:19:05 +0300 From: Vasil Dimov <vd@datamax.bg> To: freebsd-ports@freebsd.org Subject: add-plist-info and add-plist-post targets in bsd.port.mk Message-ID: <20050511061904.GA74141@sinanica.bg.datamax>
next in thread | raw e-mail | index | archive | help
--Pd0ReVV5GZGQvF3a
Content-Type: multipart/mixed; boundary="6c2NcOVqGQ03X4Wi"
Content-Disposition: inline
--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Is there any reason add-plist-info and add-plist-post targets in
bsd.port.mk are not surrounded by .if !target(...) ... .endif ?
Shouldn't they be like the others laying around - add-plist-docs and
generate-plist?
I noticed that because of the warning caused by devel/mingw32-binutils.
This port has redefined add-plist-post target and it seems that there
is no easy way for it to do the things it need in any other way.
It needs to append some dirrm commands at the end of the plist file
AFTER automatically added install-info --delete commands. How could
the be achieved without ugly hacks like redefining add-plist-docs?
sinanica:/usr/ports/devel/mingw32-binutils# make describe
"/usr/ports/Mk/bsd.port.mk", line 4847: warning: duplicate script for target "add-plist-post" ignored
...
--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="bsd.port.mk.patch"
Content-Transfer-Encoding: quoted-printable
--- bsd.port.mk.orig Tue May 10 17:15:42 2005
+++ bsd.port.mk Wed May 11 09:05:11 2005
@@ -4819,6 +4819,7 @@
.endif
.endif
=20
+.if !target(add-plist-info)
add-plist-info:
# Process GNU INFO files at package install/deinstall time
.if defined(INFO)
@@ -4837,14 +4838,17 @@
.endif
.endif
.endif
+.endif
=20
# If we're installing into a non-standard PREFIX, we need to remove that d=
irectory at
# deinstall-time
+.if !target(add-plist-post)
add-plist-post:
.if (${PREFIX} !=3D ${LOCALBASE} && ${PREFIX} !=3D ${X11BASE} && ${PREFIX}=
!=3D ${LINUXBASE} && ${PREFIX} !=3D "/usr")
@${ECHO_CMD} "@unexec rmdir %D 2> /dev/null || true" >> ${TMPPLIST}
.else
@${DO_NADA}
+.endif
.endif
=20
.if !target(install-rc-script)
--6c2NcOVqGQ03X4Wi--
--Pd0ReVV5GZGQvF3a
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
iD8DBQFCgaPYFw6SP/bBpCARAknCAKDQ7E9WVp8wZpswHmfUPJ5qyCF7zgCfbslo
3o6jZ7TcdEkDUFsuWC8NoIQ=
=rvMQ
-----END PGP SIGNATURE-----
--Pd0ReVV5GZGQvF3a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050511061904.GA74141>