Date: Fri, 22 Jul 2005 19:32:16 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Florent Thoumie <flz@xbsd.org> Cc: Jeremie Le Hen <jeremie@le-hen.org>, freebsd-ports@FreeBSD.org, edwin@FreeBSD.org Subject: Re: ngrep and libpcap from ports Message-ID: <20050722173215.GR39292@obiwan.tataz.chchile.org> In-Reply-To: <1122050545.97024.2.camel@cream.xbsd.org> References: <20050722150032.GP39292@obiwan.tataz.chchile.org> <1122050545.97024.2.camel@cream.xbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4VrXvz3cwkc87Wze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Florent,
> > This patch will link against the libpcap from ports if it exists.
> > I'm not sure this is the correct way to write this, feel free to change
> > it's needed.
>
> I wouldn't fix it that way because it would lead to unexpected
> behavior.
>
> I'd use base pcap includes unless WITH_PORTS_PCAP is defined
> (which add pcap to LIB_DEPENDS).
Thanks for your reply. I'll take it as the way to go it as I'm
convinced you are far more experienced in ports than I am.
Here is the updated patch. Note nevertheless that adding
--with-pcap-includes=${PREFIX}/include
to CONFIGURE_ARGS is required or ngrep configure script will fail
miserably with the message I showed in my previous mail.
Regards,
--
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
--4VrXvz3cwkc87Wze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ngrep_libpcap_port.patch"
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/ngrep/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile 24 Feb 2005 06:28:20 -0000 1.18
+++ Makefile 22 Jul 2005 17:29:32 -0000
@@ -31,6 +31,11 @@
.include <bsd.port.pre.mk>
+.if defined(WITH_PORTS_PCAP)
+CONFIGURE_ARGS+=--with-pcap-includes=${PREFIX}/include
+LIB_DEPENDS= pcap.2:${PORTSDIR}/net/libpcap
+.endif
+
post-install:
.if !defined(NOPORTDOCS)
@${MKDIR} ${DOCSDIR}
--4VrXvz3cwkc87Wze--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050722173215.GR39292>