Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 Nov 2005 16:59:55 +0100
From:      Alexander Leidinger <Alexander@Leidinger.net>
To:        Watanabe Kazuhiro <CQG00620@nifty.ne.jp>
Cc:        freebsd-multimedia <freebsd-multimedia@freebsd.org>
Subject:   Re: [patch] stereo input is mixed to monaural via SoundBlaster16 recording mixer
Message-ID:  <20051108165955.ge235sro0848csok@netchild.homeip.net>
In-Reply-To: <20051108153556.C856C253D6@mail.asahi-net.or.jp>
References:  <20051108153556.C856C253D6@mail.asahi-net.or.jp>

next in thread | previous in thread | raw e-mail | index | archive | help
Watanabe Kazuhiro <CQG00620@nifty.ne.jp> wrote:

> 	if (src & SOUND_MASK_MIC)
> -		recdev |= 0x01; /* mono mic */
> +		recdev_l |= 0x01; /* mono mic */
> +		recdev_r |= 0x01;

If I understand this correctly, this feeds the monaural signal to the left
and the right channel. When we have a mono input, do we really want to have
the same input doubled? I don't do any recording, so I don't know how most
programs handle this, but IMHO it's a waste of resources and if the source
is only able to deliver a mono-signal, the recording should only be possible
in mono.

Does this sound sane?

Be warned, if you proceed to submit such patches, we may want to lure you
into becomming a committer...

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
ARCHDUKE FERDINAND FOUND ALIVE --
    FIRST WORLD WAR A MISTAKE





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051108165955.ge235sro0848csok>