Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Jan 2006 20:02:53 +0300
From:      Dmitry Marakasov <amdmi3@mail.ru>
To:        Sergey Matveychuk <sem@FreeBSD.org>
Cc:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/91775: New port: graphics/gnash GNU Flash movie player
Message-ID:  <20060114170253.GB1114@hades.panopticon>
In-Reply-To: <43C8E4EC.7030703@FreeBSD.org>
References:  <43C8E4EC.7030703@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Sergey Matveychuk (sem@FreeBSD.org) wrote:
 
> 1) I think it's better to use a version number for port number, not
> snapshot. Just like that:
> PORTVERSION=0.7
> DISTNAME=${PORTNAME}-20051226
That's nonapparent. It's strange that newborn project has version 0.7,
maybe the version won't be changed between snapshot releases.
Still I've changed the version, as 0.7 can be easily changed back to
2006xxxx style without bumping the PORTEPOCH, if it's needed.

> 2) It's better to use not only MASTER_SITE but mirrors too
> (MASTER_SITE_GNU).
I didn't find gnash on any of MASTER_SITE_GNU. Seems like it's only
available from current MASTER_SITE for now.

> 3) Problem with ldconfig will be appeared after reboot. You should
> either place shared libs in a common place (PREFIX/lib) or use RC script
> to run ldconfig on booting (like mysql-client do).
I've found a better way to fix that, by adding -Wl,--rpath to LDFLAGS.
So no mess in PREFIX/lib and no unnecessary scripts in rc.d :)

> 4) I'm not sure how .omf file should be processed but it should some way
> (see INSTALLS_OMF in bsd.gnome.mk). Using of USE_GNOME=something will
> fix an extra dirs problem (Ion-Mihai Tetcu pointed to).
> I'm not familar with a GNOME stuff but I'll try to clarify how it should
> be processed.
Yes, thanks for the hint. USE_GNOME=gnomehier does the thing.

Here's updated version of the port.

--- gnash-0.7.shar begins here ---
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	gnash
#	gnash/Makefile
#	gnash/distinfo
#	gnash/pkg-descr
#	gnash/pkg-plist
#
echo c - gnash
mkdir -p gnash > /dev/null 2>&1
echo x - gnash/Makefile
sed 's/^X//' >gnash/Makefile << 'END-of-gnash/Makefile'
X# New ports collection makefile for:	gnash
X# Date created:				12 Jan 2006
X# Whom:					Dmitry Marakasov <amdmi3@mail.ru>
X#
X# $FreeBSD$
X#
X
XPORTNAME=	gnash
XPORTVERSION=	0.7
XCATEGORIES=	graphics
XMASTER_SITES=	http://www.gnu.org/software/gnash/releases/
XDISTNAME=	${PORTNAME}-20051226
X
XMAINTAINER=	amdmi3@mail.ru
XCOMMENT=	GNU Flash movie player
X
XLIB_DEPENDS=	png.5:${PORTSDIR}/graphics/png \
X		jpeg.9:${PORTSDIR}/graphics/jpeg
X
XUSE_X_PREFIX=	yes
XUSE_GNOME=	gnomehier
XUSE_SDL=	sdl mixer
XUSE_BZIP2=	yes
XUSE_GL=		yes
XUSE_GMAKE=	yes
XUSE_REINPLACE=	yes
XGNU_CONFIGURE=	yes
XINSTALLS_OMF=	yes
XUSE_GCC=	3.4+
X
XWRKSRC=		${WRKDIR}/${PORTNAME}-0.7
X
XCPPFLAGS=	`${SDL_CONFIG} --cflags` -I${X11BASE}/include
XLDFLAGS=	`${SDL_CONFIG} --libs` -L${X11BASE}/lib -Wl,--rpath,${PREFIX}/lib/gnash
X
XCONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
XCONFIGURE_ARGS=	--program-prefix=''
X
XINSTALLS_SHLIB=	yes
XLDCONFIG_DIRS=	%%PREFIX%%/lib %%PREFIX%%/lib/gnash
X
XMAN1=		gnash.1
X
X# As the project was just recently announed, firefox plugin doesn't work
X# correctly yet. You can still try it with specifying WITH_FIREFOX=yes as
X# make parameter - feel free to mail reports (preferrably of success) and
X# your ideas to port maintainer.
X# See also http://lists.gnu.org/archive/html/gnash/
X
XOPTIONS=	XML "Enable support for xml and xmlsocket" off
X#		FIREFOX "Build firefox plugin" off
X
X.include <bsd.port.pre.mk>
X
X.if defined(WITH_FIREFOX)
XBUILD_DEPENDS+=		${X11BASE}/bin/firefox-config:${PORTSDIR}/www/firefox
XCONFIGURE_ARGS+=	--enable-plugin
XCPPFLAGS+=		`firefox-config --cflags`
XLDFLAGS+=		`firefox-config --libs`
XPLIST_SUB=		PLUGIN:=""
X.else
XPLIST_SUB=		PLUGIN:="@comment "
X.endif
X
X.if defined(WITH_XML)
XBUILD_DEPENDS+=		${LOCALBASE}/bin/xml2-config:${PORTSDIR}/textproc/libxml2
XCPPFLAGS+=		`xml2-config --cflags`
XLDFLAGS+=		`xml2-config --libs`
X.else
XCONFIGURE_ARGS+=	--disable-xml
X.endif
X
Xpost-extract:
X	@${FIND} ${WRKSRC} -name "*.cpp" -o -name "*.h" | \
X		${XARGS} ${REINPLACE_CMD} -e "s|$$(${PRINTF} '\r')||g"
X
Xpost-patch:
X	@${REINPLACE_CMD} -e '/INCLUDES/ s|$$(srcdir)||' ${WRKSRC}/libgeometry/Makefile.in ${WRKSRC}/libbase/Makefile.in
X	@${REINPLACE_CMD} -e 's|malloc.h|stdlib.h|' ${WRKSRC}/libbase/dlmalloc.c ${WRKSRC}/libbase/dlmalloc.h
X	@${REINPLACE_CMD} -e '/APPLE_CC/ s|^.*$$|#if 0|' ${WRKSRC}/libbase/utility.cpp
X	@${REINPLACE_CMD} -e '/cd doc/ s|^.*$$|	@true|; /DIRS/ s/ doc//' ${WRKSRC}/Makefile.in
X	@${REINPLACE_CMD} -e '/^include_HEADERS/ s|^|#|' ${WRKSRC}/Makefile.in
X	@${REINPLACE_CMD} -e '/FIREFOX_PLUGINS=.*FIREFOX_LIBS/ s|^.*$$|FIREFOX_PLUGINS=${X11BASE}/lib/browser_plugins|' ${WRKSRC}/configure
X.if !defined(WITH_FIREFOX)
X	@${REINPLACE_CMD} -e 's|firefox-config|firefox-config1|g' ${WRKSRC}/configure
X.endif
X
X.if defined(WITH_FIREFOX)
Xpre-install:
X	${MKDIR} ${PREFIX}/lib/browser_plugins
X.endif
X
Xpost-install:
X	${INSTALL_MAN} ${WRKSRC}/doc/C/gnash.1 ${PREFIX}/man/man1
X	${MKDIR} ${PREFIX}/share/gnome/omf/gnash
X	${INSTALL_DATA} ${WRKSRC}/doc/C/gnash.omf ${PREFIX}/share/gnome/omf/gnash
X.if !defined(NOPORTDOCS)
X	${MKDIR} ${DOCSDIR}/images
X.for i in gnash.html gnash.pdf gnash.xml legal.xml
X	${INSTALL_DATA} ${WRKSRC}/doc/C/${i} ${DOCSDIR}
X.endfor
X	${INSTALL_DATA} ${WRKSRC}/doc/C/images/* ${DOCSDIR}/images
X.endif
X
X.include <bsd.port.post.mk>
END-of-gnash/Makefile
echo x - gnash/distinfo
sed 's/^X//' >gnash/distinfo << 'END-of-gnash/distinfo'
XMD5 (gnash-20051226.tar.bz2) = 16d3261d0ec22be7cc738e30b42dc9ac
XSHA256 (gnash-20051226.tar.bz2) = 49a1e958d1cf62e8cda1605abeb61b7924f3f0bb5978f78ff08d657243263350
XSIZE (gnash-20051226.tar.bz2) = 742001
END-of-gnash/distinfo
echo x - gnash/pkg-descr
sed 's/^X//' >gnash/pkg-descr << 'END-of-gnash/pkg-descr'
XGnash is a GNU Flash movie player. Till now it has been possible
Xto play flash movies with proprietary software. While there are a
Xfew free flash players, none supports anything higher than SWF v4
Xat best. Gnash is based on GameSWF, and supports many SWF v7 features.
X
XFeatures:
X- Runs standalone
X  Gnash can run standalone to play flash movies.
X- Firefox plugin
X  Gnash can also run as a plugin from within Firefox.
X- SWF v7 compliant
X  Gnash can play many current flash movies.
X- XML Message server
X  Gnash also supports an XML based message system as is documented
X  in the Flash Format specification.
X- High Quality Output
X  Gnash uses OpenGL for rendering the graphics.
X- Free Software
X  Gnash is 100% free software. For more information on the GPL, go
X  to the Free Software Foundation web site.
X
XWWW: http://www.gnu.org/software/gnash/
END-of-gnash/pkg-descr
echo x - gnash/pkg-plist
sed 's/^X//' >gnash/pkg-plist << 'END-of-gnash/pkg-plist'
Xbin/gnash
Xbin/gparser
Xbin/gprocessor
Xlib/gnash/libbase.a
Xlib/gnash/libbase.la
Xlib/gnash/libbase.so
Xlib/gnash/libbase.so.0
Xlib/gnash/libgeometry.a
Xlib/gnash/libgeometry.la
Xlib/gnash/libgeometry.so
Xlib/gnash/libgeometry.so.0
Xlib/gnash/libserver.a
Xlib/gnash/libserver.la
Xlib/gnash/libserver.so
Xlib/gnash/libserver.so.0
X%%PLUGIN:%%lib/browser_plugins/libgnash.so
Xshare/gnome/omf/gnash/gnash.omf
X%%PORTDOCS%%%%DOCSDIR%%/gnash.html
X%%PORTDOCS%%%%DOCSDIR%%/gnash.pdf
X%%PORTDOCS%%%%DOCSDIR%%/gnash.xml
X%%PORTDOCS%%%%DOCSDIR%%/legal.xml
X%%PORTDOCS%%%%DOCSDIR%%/images/car_crash.png
X@dirrm lib/gnash
X@dirrm share/gnome/omf/gnash
X%%PORTDOCS%%@dirrm %%DOCSDIR%%/images
X%%PORTDOCS%%@dirrm %%DOCSDIR%%
END-of-gnash/pkg-plist
exit

--- gnash-0.7.shar ends here ---

-- 
Best regards,
 Dmitry                          mailto:amdmi3@mail.ru



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060114170253.GB1114>