Date: Wed, 19 Apr 2006 07:26:27 +0000 From: Marco van Tol <marco@tols.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: Per CPU cpu-statistics under SMP Message-ID: <20060419072627.GA66012@tols.org> In-Reply-To: <200604181838.27713.jhb@freebsd.org> References: <20060412215021.GB1146@tols.org> <20060417134825.GA47043@tols.org> <20060418221505.GC58081@tols.org> <200604181838.27713.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 18, 2006 at 06:38:26PM -0400, John Baldwin wrote: > On Tuesday 18 April 2006 18:15, Marco van Tol wrote: [...] > > I'm trying to apply the patch. Tried it to both todays current and todays > > RELENG_6, but both have failing hunks in sys/kern/kern_clock.c. > > The rest succeeds. > > > > I can do two things: > > - Try to manually patch it against todays current. > > - re-checkout todays RELENG_6, and download the relevant files from the > > cvsweb interface from the date you posted the patch from that days > > CURRENT. Then try to apply the patch. > > > > For the latter it may break the kernelbuild, but I'm very tempted to try > > that one ahead of the manual patching attempt. ;) > > > > I'll keep you posted on how far I'm getting with this. Guess I should have > > gone straight to current the day you posted the patch. Sorry. > > Ah, hmm. On 6.x we don't have per-thread stat ticks yet, which is > probably why it is failing. It also isn't safe to move sched_lock > down either on 6.x. You can still apply the rest of the patch by > hand, just leave the 'mtx_lock_spin(&sched_lock)' where it is and > change all the 'cp_time[FOO]++' to 'PCPU_LAZY_INC(cp_time[FOO])'. OK, thanks. What I will do is replace my gentoo partition with a BSD current partition so I don't loose my workstation as it were, and use that to work on this. Will let you know how that goes. Thanks. Marco -- Als de redding het hoogst is, is de nood nabij!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060419072627.GA66012>