Date: Wed, 19 Apr 2006 13:50:36 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Larry Rosenman <ler@lerctr.org> Cc: freebsd-ports@freebsd.org, 'Kris Kennaway' <kris@obsecurity.org> Subject: Re: -fPIC for a port that is just a library on amd64? Message-ID: <20060419175036.GA71370@xor.obsecurity.org> In-Reply-To: <023e01c663d7$9a10d270$0202fea9@aus.pervasive.com> References: <20060419173254.GB70979@xor.obsecurity.org> <023e01c663d7$9a10d270$0202fea9@aus.pervasive.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2006 at 12:35:07PM -0500, Larry Rosenman wrote: > Kris Kennaway wrote: > > On Wed, Apr 19, 2006 at 09:52:38AM -0500, Larry Rosenman wrote: > >> What's the best way to get a port to add -fPIC to the compile for a > >> port that generates just an archive library (textproc/libxdiff)? > >>=20 > >> I was able to force the issue with CFLAGS=3D-fPIC make;CFLAGS=3D-fpic > >> make install, but it would be nice if the port could do it > >> automagically.=20 > >=20 > > It would be nice if the software was already correct so it happened > > automatically :-) > >=20 > >> The issue is that the pecl-xdiff extension uses this library and > >> wants to be a shared object. > >=20 > > If it's only compiling a shared library object (not static object or > > other binaries), then adding CFLAGS+=3D -fPIC to the port makefile is > > acceptable. Better, add it to the software makefile and contribute > > your patch back upstream. > >=20 > > Kris >=20 > It's just compiling a static object (a libxdiff.a). >=20 > I just submitted a patch to the port that if ${MACHINE} =3D=3D amd64=20 > I do the CFLAGS+=3D -fPIC > but I'm not sure that's acceptable to you folks on portmgr. How is this object used? Is it really supposed to be static? Kris --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFERnhsWry0BWjoQKURAldjAKDxph1RHwBPtbZ77CgqKGIPwTo2pgCgrACJ mWnD6/cQwww7plzyOs/ITcw= =FuWt -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060419175036.GA71370>