Date: Wed, 17 May 2006 13:06:30 -0800 From: Beech Rintoul <beech@alaskaparadise.com> To: freebsd-ports@freebsd.org Subject: Help with makefile options Message-ID: <200605171306.42686.beech@alaskaparadise.com>
next in thread | raw e-mail | index | archive | help
--nextPart1452417.8bYFHeCHNK Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline I submitted an update and the comitter didn't like the way options were=20 defined. He said: > =A0On Wednesday 17 May 2006 03:56, you wrote: > =A0> Could you please check the way you use OPTIONS against the respective > =A0> PH chapter ? (check "on" options against WITHOUT and "off" against W= ITH) > =A0> (I don't think you actually break something because the "bug" mentio= ned > =A0> there only affects make depend /describe, but let's be consistent). "Due to a deficiency in the infrastructure, you can only test WITH_* variables for options, which are OFF by default, and WITHOUT_* variables for options, which defaults to ON" And an example: OPTIONS=3D =A0 =A0 =A0 =A0IPV6 "Use IPv6" off \ =2Eif defined(WITH_IPV6) =2Eif defined(WITHOUT_IPV6) second .if should be: ,if !defined(WITH_IPV6) =A0> grep IFSESSION Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 IFSESSION "Include mod_ifsession" on \ =2Eif defined(WITH_IFSESSION) should be .if !defined(WITHOUT_IFSESSION) How would this work? It looks to me like they would be defined as opposite = of=20 what they are intended to do. Could someone explain this to me? I seem to b= e=20 missing something. Beech =2D-=20 =2D------------------------------------------------------------------------= =2D------------- Beech Rintoul - Sys. Administrator - beech@alaskaparadise.com /"\ ASCII Ribbon Campaign | Alaska Paradise \ / - NO HTML/RTF in e-mail | 201 East 9Th Avenue Ste.310 X - NO Word docs in e-mail | Anchorage, AK 99501 / \ - Please visit Alaska Paradise - http://www.alaskaparadise.com =2D------------------------------------------------------------------------= =2D------------- --nextPart1452417.8bYFHeCHNK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEa5Bip5D0B1NlT4URAo7fAJ9jgMWiHdkdnjTcGFkYhPjMxpIQ7wCfZSww bB3Wl9Z+lmOWDbTKI10DBT8= =Hfl+ -----END PGP SIGNATURE----- --nextPart1452417.8bYFHeCHNK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605171306.42686.beech>