Date: Thu, 8 Jun 2006 17:58:29 -0700 (PDT) From: Doug White <dwhite@gumbysoft.com> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: freebsd-rc@freebsd.org Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev state Message-ID: <20060608175640.R50887@carver.gumbysoft.com> In-Reply-To: <20060609005422.GA25288@odin.ac.hmc.edu> References: <200606082130.k58LUYQO069255@freefall.freebsd.org> <20060609005422.GA25288@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 8 Jun 2006, Brooks Davis wrote: > On Thu, Jun 08, 2006 at 09:30:34PM +0000, Doug White wrote: >> The following reply was made to PR conf/94377; it has been noted by GNATS. >> >> From: Doug White <dwhite@gumbysoft.com> >> To: Rostislav Krasny <rosti.bsd@gmail.com> >> Cc: Florent Thoumie <flz@FreeBSD.org>, Doug White <dwhite@FreeBSD.org>, >> bug-followup@FreeBSD.org >> Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev >> state >> Date: Thu, 8 Jun 2006 10:36:05 -0700 (PDT) >> >> On Thu, 8 Jun 2006, Rostislav Krasny wrote: >> >> > I've seen that patch just today, when it is already MFCed. I think it >> > could be simpler. Instead of >> > >> > [ "x${seeded}" != "x" ] && [ ${seeded} -eq 0 ] >> > >> > you can write just >> > >> > [ "${seeded}" = "0" ] >> > >> > and it will be still correct against sysctl failing and returning an >> > empty string. >> >> No, because if ${seeded} is empty, the shell interprets the test as >> >> [ = "0" ] >> >> which results in a syntax error. The 'x' in the first test is significant. > > Not true. The 'x' bit has been unnecessicary 31337 for quite some > time IMO. If you didn't quote ${seeded} then it would be, but > "${variable_that_expands_to_null}" is "". Otherwise -z and -n wouldn't > work. -z and -n are unary operations. They just check if the *have* an argument. = is a comparison operation and requires two operands. If it offends you two that much then file a new PR. I honestly don't give a crap. -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060608175640.R50887>