Date: Tue, 11 Jul 2006 15:07:42 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: atkin901@yahoo.com Cc: freebsd-acpi@freebsd.org Subject: Re: sio0 wiring to a resource patch Message-ID: <20060711.150742.1649768833.imp@bsdimp.com> In-Reply-To: <e90md5$q6f$1@sea.gmane.org> References: <20060711.005639.-233674225.imp@bsdimp.com> <e90md5$q6f$1@sea.gmane.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <e90md5$q6f$1@sea.gmane.org>
othermark <atkin901@yahoo.com> writes:
: M. Warner Losh wrote:
:
: > Please find enclosed an experimental patch. It does two things.
: [...]
: > Anyway, please test these patches out and let me know if you have
: > problems.
: >
: > Warner
:
: (sorry about the wrapping here)
:
: I tried to build it with a csup from this morning, and I get this
: compilation error:
:
:
: cc -c -O -pipe -march=pentiumpro -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
: opt_global.h -fno-common -finline-limit=8000 --param
: inline-unit-growth=100 --param
: large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror /usr/src/sys/dev/sio/sio_pci.c
: /usr/src/sys/dev/sio/sio_pci.c: In function `sio_pci_kludge_unit':
: /usr/src/sys/dev/sio/sio_pci.c:131: warning: implicit declaration of
: function `device_set_unit'
: /usr/src/sys/dev/sio/sio_pci.c:131: warning: nested extern declaration of
: `device_set_unit'
: *** Error code 1
:
: Stop in /usr/obj/usr/src/sys/POGO.
: *** Error code 1
:
: Stop in /usr/src.
: *** Error code 1
:
: Stop in /usr/src.
:
: A full find on /usr/src only reveals that one instance of usage that needs
: to be changed.
Doh! I forgot to include that in my patch. My mistake. Comes from
doing too many things in that branch.
http://people.freebsd.org/~imp/wire-unit.diff
Basically, delete the sio_pci_kludge_unit function, remove its
declaration and the one place it calls it.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060711.150742.1649768833.imp>