Date: Sat, 12 Aug 2006 14:53:08 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Dmitry Morozovsky <marck@rinet.ru> Cc: current@FreeBSD.org Subject: Re: gjournal panic on RELENG_6 Message-ID: <20060812125308.GA2351@garage.freebsd.pl> In-Reply-To: <20060812152011.H25511@woozle.rinet.ru> References: <20060812152011.H25511@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--xXmbgvnjoT4axfJE Content-Type: multipart/mixed; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2006 at 03:24:04PM +0400, Dmitry Morozovsky wrote: > Hi there >=20 > remounting gjournalled filesystem read-only leaves some kernel structures= =20 > unflushed, leading to a panic. >=20 > Reproduce sequence: >=20 > /ar is gjournalled >=20 > mount -t devfs devfs /ar/tmp > mount -u -r /ar >=20 > ... after several seconds (I suppose on gjournal switch) kernel panicked: Thanks. The attached patch should fix the problem. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: attachment; filename="g_journal_readonly.patch" --- g_journal.c.orig Sat Aug 12 14:52:13 2006 +++ g_journal.c Sat Aug 12 14:08:57 2006 @@ -2850,6 +2850,8 @@ TAILQ_FOREACH(mp, &mountlist, mnt_list) { if (mp->mnt_gjprovider == NULL) continue; + if (mp->mnt_flag & MNT_RDONLY) + continue; desc = g_journal_find_desc(mp->mnt_stat.f_fstypename); if (desc == NULL) continue; --cWoXeonUoKmBZSoM-- --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFE3c80ForvXbEpPzQRAix8AJ9pOybrMZMewcx2E5zKaIW3a75/sQCgr/KE 6pPzn7TV+N5wp/olK9Zgpm4= =J70A -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060812125308.GA2351>