Date: Mon, 28 Aug 2006 22:19:45 +0200 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Daniel Gerzo <danger@FreeBSD.org> Cc: doc@freebsd.org Subject: Re: merge query-pr.cgi and query-pr-summary.cgi, fix -T mode with new perl Message-ID: <20060828201944.GE1033@zaphod.nitro.dk> In-Reply-To: <51457742.20060827154106@rulez.sk> References: <1418203821.20060822110342@rulez.sk> <20060827130122.GB1149@zaphod.nitro.dk> <51457742.20060827154106@rulez.sk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2006.08.27 15:41:06 +0200, Daniel Gerzo wrote: > Sunday, August 27, 2006, 3:01:23 PM, you wrote: > > > On 2006.08.22 11:03:42 +0200, Daniel Gerzo wrote: > > >> I have produced a patch [1] which combines two cgi scripts -- > >> query-pr.cgi and query-pr-summary.cgi. It merges functionality of > >> query-pr.cgi into -summary.cgi, but if we want to commit this I > >> would recommend to rename query-pr-summary.cgi to query-pr.cgi > >> (maybe symlink would be even better?) once commited. > > > What exactly is the advantage of combining the two into one CGI > > script? > > It's not big deal... > > http://www.freebsd.org/cgi/query-pr.cgi?pr=35647 Hey, Ah, I did seem to recall the suggestion from somewhere. I generally like keeping the CGI scripts as simple as possible - it makes them easier to read and modify. Especially scripts which do multiple tasks based on how they are called have a tendency to get more complicated than needed (at least that's my experience). >From my reading of the PR the problem is mainly that we have two different HTML pages to look up a PR by number and to search. A much simpler way to solve this would IMO be to have one HTML page with both forms which then simply submits to the right CGI script. This could either be a seperate HTML page or the form could just included in query-pr-summery.cgi. How does that sound instead of completely merging the scripts? -- Simon L. Nielsen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060828201944.GE1033>