Date: Wed, 1 Nov 2006 10:51:00 -0500 From: John Baldwin <jhb@freebsd.org> To: john@utzweb.net Cc: freebsd-acpi@freebsd.org Subject: Re: Serious Progess Re: smbios.ko probes successfully if i disable acpi sysresource, fails if i do not Message-ID: <200611011051.00658.jhb@freebsd.org> In-Reply-To: <51211.69.93.78.27.1162338464.squirrel@69.93.78.27> References: <FBFBCF13-54B0-4825-A115-4CDDE4215CD7@utzweb.net> <200610301519.24918.jhb@freebsd.org> <51211.69.93.78.27.1162338464.squirrel@69.93.78.27>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 31 October 2006 18:47, john@utzweb.net wrote: > > On Thursday 26 October 2006 22:19, John Utz wrote: > >> > >> On Oct 26, 2006, at 2:14 PM, Nate Lawson wrote: > >> > >> > John Baldwin wrote: > >> >> On Thursday 26 October 2006 12:28, Nate Lawson wrote: > >> >>>> note that startaddr for smbios is 0xf000, bios.c looks for > >> >>>> pnpbios and pcibios starting at 0xe000 and completely ignores > >> >>>> smbios. > >> >>> Are you using bus_alloc_resource() or the equivalent to get the > >> >>> resources in your driver? > >> > >> this was the us$64K question, thankyou for answering it! > >> > >> man bus_alloc_resource sez 'dont use this any earlier than attach, > >> and smbios.c (and several other things) are using it in probe(). > >> > >> once i yanked that out of probe, then it cohabitates with acpi > > > > They should likely use pmap_mapbios() (pmap_mapdev() on 6.x) to locate and > > map > > tables instead. > > So i actually do use pmap_mapdev to get a handle to the table, but i dont > do that in smbios_attach, i do it in a function written to walk the table. > > but, as i alluded to previously, the original author used > bus_alloc_resource() in smbios_attach() are you saying that i should use > pmap_mapdev() in smbios_attach *instead* of bus_alloc_resource()? Yes. Firmware tables are not resources (at least IMHO). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611011051.00658.jhb>