Date: Thu, 21 Dec 2006 18:01:01 -0800 From: John-Mark Gurney <gurney_j@resnet.uoregon.edu> To: Robert Watson <rwatson@FreeBSD.org> Cc: Daniel Eischen <deischen@FreeBSD.org>, Julian Elischer <jelischer@ironport.com>, David Xu <davidxu@FreeBSD.org>, freebsd-arch@FreeBSD.org Subject: Re: close() of active socket does not work on FreeBSD 6 Message-ID: <20061222020101.GC4982@funkthat.com> In-Reply-To: <20061221152115.U83974@fledge.watson.org> References: <32874.1165905843@critter.freebsd.dk> <20061220153126.G85384@fledge.watson.org> <Pine.GSO.4.64.0612201308220.23942@sea.ntplx.net> <200612210820.09955.davidxu@freebsd.org> <4589E7D2.9010608@ironport.com> <20061221152115.U83974@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote this message on Thu, Dec 21, 2006 at 15:22 +0000:
> >I think you are only intersted in treads that are sleeping.. so you allow
> >a sleeping thread to save a pointer to the fd (or whatever) on which it is
> >sleeping, along with the sleep address.
> >
> >items that are not sleeping are either already returning, or are going to
> >sleep, in which case they can check at that time.
>
> Hence my question about select and poll: should they throw an exception
> state when a file descriptor is closed out from under them? They often
> sleep on hundreds or thousands of file descriptors, and not just one.
IMO, your program is buggy if you close the file descriptor before
everything is out of the kernel wrt the fd... It means that your close
statement isn't waiting for things to be cleanly shut down, and that
you still have dangling reference counts to the parts of the code that
is in the kernel...
I used to expect something similar w/ an kqueue based event driven
web server, and found that I had bugs due to assuming that I could
close it whenever I want... What happens if you close the fd between
the time select returns and you process it? What happens if the fd
gets closed, and another thread (or an earlier fd that accepts
connections) reuses that fd? And then youre state machine isn't read
to get an event since it isn't suppose to get one yet...
The kernel isn't buggy wrt closing a fd when another thread is using
it, it's the program that's buggy...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061222020101.GC4982>