Date: Sun, 4 Mar 2007 18:55:50 +0100 From: Ed Schouten <ed@fxq.nl> To: hackers@freebsd.org Cc: Divacky Roman <xdivac02@stud.fit.vutbr.cz> Subject: Re: investigation of Giant usage in kernel Message-ID: <20070304175550.GA18397@hoeg.nl> In-Reply-To: <20070304141136.GA4935@stud.fit.vutbr.cz> References: <20070304141136.GA4935@stud.fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, I took a grep on the kernel source and took a look to Giant usage as well. I too have a question about locking in uipc_domain.c: The file has a mutex, dom_mtx, which protects the 'domain list lock', which could be declared static by the way. The strange thing is that it isn't used to lock the domain list lock in any way. It is only used to lock the domain_init_status variable. Wouldn't it be better to rename it to something better? The pf_proto_register() routine locks and unlocks Giant. It looks like s/Giant/dom_mtx/ would be enough to remove the usage of Giant from uipc_domain.c. Yours, --=20 Ed Schouten <ed@fxq.nl> WWW: http://g-rave.nl/ --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF6wgm52SDGA2eCwURAqCjAJ9ejEph3fcgNKhV+iJICaEJnZ2pQgCfWOMQ SAbzWmXW4chApkynYUVLBv4= =rEjn -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070304175550.GA18397>