Date: Fri, 30 Mar 2007 05:16:13 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: current@freebsd.org, Nate Lawson <nate@root.org> Subject: Re: libfetch ftp patch for less latency Message-ID: <20070329191613.GB827@turion.vk2pj.dyndns.org> In-Reply-To: <86k5wzq4vx.fsf@dwp.des.no> References: <460AE39B.4070706@root.org> <86odmcqylx.fsf@dwp.des.no> <200703291905.00192.pieter@degoeje.nl> <86k5wzq4vx.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--i9LlY+UWpKt15+FH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-Mar-29 20:30:26 +0200, Dag-Erling Smrgrav <des@des.no> wrote: >Libfetch used to do what Nate suggests, and it was changed to the >current behaviour because we encountered servers in the field with >which it didn't work. At first glance, the current behaviour does seem unnecessary and Nate's patch seems an "obvious" improvement. Having a comment near _ftp_cwd() explaining the current behaviour and why it isn't possible to pass a pathname to CWD would have saved Nate some effort and removed the need for this thread. Sometimes, it is as important to document why an alternative algorithm was not chosen as it is to document what the code is doing. --=20 Peter Jeremy --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGDBB9/opHv/APuIcRAhS2AKDAGVeajrhKsPQ2u9uQtdhmS125TgCggJUm WlgIGnSjwOh6S1wGvklxT3g= =bfz4 -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070329191613.GB827>