Date: Sat, 14 Apr 2007 21:39:22 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Dejan Lesjak <dejan.lesjak@ijs.si> Cc: x11@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: Upgrade script Message-ID: <20070415013921.GA68262@xor.obsecurity.org> In-Reply-To: <200704142311.47387.dejan.lesjak@ijs.si> References: <20070414194028.GB2313@xor.obsecurity.org> <20070414195441.GA17321@xor.obsecurity.org> <200704142311.47387.dejan.lesjak@ijs.si>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Apr 14, 2007 at 11:11:47PM +0200, Dejan Lesjak wrote:
> On Saturday 14 April 2007 21:54:41 Kris Kennaway wrote:
> > On Sat, Apr 14, 2007 at 03:40:28PM -0400, Kris Kennaway wrote:
> > > * Before spamming /usr/local there needs to be a check that no files
> > > will be skipped (since you are using tar -k to avoid overwriting
> > > existing files). Probably something using find -type f -o -type l and
> > > then comm(1) would be appropriate; the user should be warned about
> > > these conflicts and either bail out until they resolve them, or just
> > > proceed and let them deal with them by hand from the backup tarball.
>
> I've updated the script with this and some other stuff, it's on the same
> place.
Thanks. One more thing I spotted is that it doesn't handle
non-default X11BASE or LOCALBASE. Probably the way to do this is to
use
PORTSDIR?=/usr/ports
X11BASE=`make -f ${PORTSDIR}/Mk/bsd.port.mk -V X11BASE`
or similar. Using bsd.port.mk is so it picks up the default value,
and includes /etc/make.conf to check for override. It also DTRT if
X11BASE is set in the environment.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQFGIYJIWry0BWjoQKURAvCRAJ9VX5RXL0tJDrnIWJFdYWevpngxaACg+9P8
N7ylV35LTde8xzhn139O3T4=
=RhQW
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070415013921.GA68262>